Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: setup pre commit hook to check java format #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

build: setup pre commit hook to check java format #28

wants to merge 1 commit into from

Conversation

ChristianMurphy
Copy link
Member

  • updates gradle wrapper to latest version to enable ghooks to be used.
  • enables ghooks plugin for gradle
  • adds google java format pre commit hook
  • adds test check file output to gitignore

resolves #25

@ChristianMurphy
build: setup pre commit hook to check java format
811b162 
* updates gradle wrapper to latest version to enable ghooks to be used.
* enables ghooks plugin for gradle
* adds google java format pre commit hook
* adds test check file output to gitignore

resolves openequella#25
@ChristianMurphy ChristianMurphy requested a review from cbeach47 June 10, 2020 00:07
@ChristianMurphy
Copy link
Member Author

ChristianMurphy commented Jun 10, 2020 •
edited
Loading

Also be aware, it appears some of the test suite is failing:
Screenshot_2020-06-09 Test results - Test Summary

edit probably related to the Gradle version update

@edalex-ian
Copy link
Member

May want to consider bringing in Checkstyle too for some static code analysis: https://docs.gradle.org/current/userguide/checkstyle_plugin.html

@ChristianMurphy
Copy link
Member Author

Thanks for the suggestion!
I added spotbugs over in #30, I'll make a note to look into checkstyle as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbeach47 cbeach47 Awaiting requested review from cbeach47

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup pre-commit hook for google-java-format
2 participants
@ChristianMurphy @edalex-ian